Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add the brand name in the AppBar #4449

Closed
wants to merge 4 commits into from
Closed

fix: Add the brand name in the AppBar #4449

wants to merge 4 commits into from

Conversation

saiprasad-patil
Copy link
Contributor

Added the brand name in the App Bar

  • Just added new variable, and changed the App bar text

Screenshot

WhatsApp Image 2023-08-04 at 9 44 13 PM

Fixes bug(s)

@saiprasad-patil saiprasad-patil requested a review from a team as a code owner August 5, 2023 01:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

You can test this PR on: Android

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023 •
edited
Loading

Codecov Report

Merging #4449 (80313f4) into develop (aa6632d) will decrease coverage by 0.01%.
Report is 12 commits behind head on develop.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4449      +/-   ##
===========================================
- Coverage    10.28%   10.28%   -0.01%     
===========================================
  Files          296      296              
  Lines        15232    15234       +2     
===========================================
  Hits          1567     1567              
- Misses       13665    13667       +2
Files Changed Coverage Δ
...mooth_app/lib/pages/product/edit_product_page.dart 0.50% <0.00%> (-0.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

g123k
g123k requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation is partial.
You have only changed the main page, but we should have the product name first.
Also in some languages, there is a space between the two info.

  • this bug is not only for this page, but also but all subpages

@g123k
Copy link
Collaborator

g123k commented Aug 14, 2023

Your implementation is partial. You have only changed the main page, but we should have the product name first. Also in some languages, there is a space between the two info.

  • this bug is not only for this page, but also but all subpages

Why did you close your PR @saiprasad-patil? It was possible to add the new features in it

@saiprasad-patil
Copy link
Contributor Author

I'm sorry I'll create a new PR, I'm new to Github and a beginner in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k g123k requested changes

Assignees

@saiprasad-patil saiprasad-patil

Labels
🥫 Product page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement?] Add the brand name in the AppBar
3 participants
@saiprasad-patil @codecov-commenter @g123k